fix: Move telemetry urllib context to initialize function #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marofke
force-pushed
the
marofke/telemetry-urllib-init
branch
from
eadb26e
to
fd7eb50
Compare
AWS-Samuel
approved these changes
Mar 29, 2024
marofke
force-pushed
the
marofke/telemetry-urllib-init
branch
from
fd7eb50
to
f9f6d6f
Compare
lucaseck
approved these changes
Mar 29, 2024
Signed-off-by: Caden Marofke <marofke@amazon.com>
marofke
force-pushed
the
marofke/telemetry-urllib-init
branch
from
f9f6d6f
to
42405dd
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
We're still seeing some runtime errors in DCC submitters when trying to initialize the telemetry client.
What was the solution? (How)
Move botocore's urllib3 SSL context logic into the
initializefunction, which safely tries to import botocore's SSL, or silently failsWhat is the impact of this change?
Failing to initialize telemetry shouldn't crash DCC submitters
How was this change tested?
Submitted a job successfully
Was this change documented?
N/A
Is this a breaking change?
No